This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Adding Traditional Chinese character strings.xml files for HK & Taiwan support #12719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langsmith
added
Android
friedbunny
reviewed
Aug 22, 2018
tobrun
approved these changes
Aug 23, 2018
langsmith
force-pushed
the
ls-adding-additional-chinese-characters
branch
from
6440399
to
5fa0969
Compare
|
Ok, I squashed/re-based as requested. I'm fine with either merging this as is or waiting to also resolve #12708 with this pr |
langsmith
force-pushed
the
ls-adding-additional-chinese-characters
branch
2 times, most recently
from
d41afdd
to
ed50b46
Compare
langsmith
force-pushed
the
ls-adding-additional-chinese-characters
branch
from
6f3b32b
to
21cf8e5
Compare
|
Ok @tobrun , I think this is ready. I've added the However, as you wrote in #12708, work still needs to be done to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds telem window language support for traditional Chinese characters if an Android device is set to the Hong Kong or Taiwan region
Related
cc @macro-shen @chriswu42 @suntony @springmeyer @jmkiley @lloydsheng @1ec5 @jcsg